linux-kernel - Re: [PATCH 3/3] thunderbolt: Allow clearing the key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170815071144.GI2369@lahna.fi.intel.com>
Date:   Tue, 15 Aug 2017 10:11:44 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Bernat, Yehezkel" <yehezkel.bernat@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Lukas Wunner <lukas@...ner.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] thunderbolt: Allow clearing the key

On Tue, Aug 15, 2017 at 08:19:20AM +0300, Bernat, Yehezkel wrote:
> If secure authentication of a devices fails, either because the device
> already has another key uploaded, or there is some other error sending
> challenge to the device, and the user only wants to approve the device
> just once (without a new key being uploaded to the device) the current
> implementation does not allow this because the key cannot be cleared
> once set even if we allow it to be changed.
> 
> Make this scenario possible and allow clearing the key by writing
> empty string to the key sysfs file.
> 
> Signed-off-by: Yehezkel Bernat <yehezkel.bernat@...el.com>

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>