linux-kernel - Re: [PATCH v2 0/1] add (un)patch callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.20.1708151059190.8441@pobox.suse.cz>
Date:   Tue, 15 Aug 2017 11:00:26 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Joe Lawrence <joe.lawrence@...hat.com>
cc:     live-patching@...r.kernel.org, linux-kernel@...r.kernel.org,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jessica Yu <jeyu@...nel.org>, Jiri Kosina <jikos@...nel.org>,
        Petr Mladek <pmladek@...e.com>,
        Chris J Arges <chris.j.arges@...onical.com>
Subject: Re: [PATCH v2 0/1] add (un)patch callbacks

On Tue, 8 Aug 2017, Joe Lawrence wrote:

> Hi folks,
> 
> This is v2 of the livepatch (un)patch hook/notifier/callback/etc code.
> 
> The documentation is still a little rough, but I wanted to post up the
> code for feedback before getting too far in revising it.
> 
> This implements the pre and post handlers as Josh suggested.  See
> summary of related changes below...
> 
> v2:
> - s/hooks/callbacks/g
> - implemented pre-(un)patch and post-(un)patch callbacks
>   - pre-patch and pre-unpatch callbacks run from callers of
>     klp_patch_object() and klp_unpatch_object()
>   - post-patch and post-unpatch callbacks run from
>     klp_complete_transition() and klp_module_coming/going()
> - reduce callbacks from a list to a single per-klp_object instance
> - revamp the sample callback demo
> - revamp documentation
> 
> Feedback appreciated as always.

Looks almost good to me. v3 with Josh's review should be ok.

Miroslav