linux-kernel - Re: [PATCH 1/3] thunderbolt: Remove superfluous check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeS0NN+vs+a-=gV9mLGwjqY-g=w2hvrv4yncK8J2W301A@mail.gmail.com>
Date:   Tue, 15 Aug 2017 12:32:54 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     "Bernat, Yehezkel" <yehezkel.bernat@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Lukas Wunner <lukas@...ner.de>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] thunderbolt: Remove superfluous check

On Tue, Aug 15, 2017 at 8:19 AM, Bernat, Yehezkel
<yehezkel.bernat@...el.com> wrote:
> The key size is tested by hex2bin() already (as '\0' isn't an hex digit)

Yes, and it's guaranteed (by kernelfs) that '\0' will be there sooner or later.

> Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>

I'm using @linux.intel.com, though for this tag it really doesn't matter.


-- 
With Best Regards,
Andy Shevchenko