linux-kernel - Re: [RFT 13/13] s390: virtio: constify ccw_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Aug 2017 13:11:55 +0200
From:   Cornelia Huck <cohuck@...hat.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     schwidefsky@...ibm.com, heiko.carstens@...ibm.com,
        sth@...ux.vnet.ibm.com, hoeppner@...ux.vnet.ibm.com,
        jwi@...ux.vnet.ibm.com, ubraun@...ux.vnet.ibm.com,
        maier@...ux.vnet.ibm.com, pasic@...ux.vnet.ibm.com,
        linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org
Subject: Re: [RFT 13/13] s390: virtio: constify ccw_device_id

On Tue, 15 Aug 2017 16:05:44 +0530
Arvind Yadav <arvind.yadav.cs@...il.com> wrote:

> ccw_device_id are not supposed to change at runtime. All functions
> working with ccw_device_id provided by <asm/ccwdev.h> work with
> const ccw_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/s390/virtio/virtio_ccw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/virtio/virtio_ccw.c b/drivers/s390/virtio/virtio_ccw.c
> index b18fe20..b43dbba 100644
> --- a/drivers/s390/virtio/virtio_ccw.c
> +++ b/drivers/s390/virtio/virtio_ccw.c
> @@ -1307,7 +1307,7 @@ static int virtio_ccw_cio_notify(struct ccw_device *cdev, int event)
>  	return rc;
>  }
>  
> -static struct ccw_device_id virtio_ids[] = {
> +static const struct ccw_device_id virtio_ids[] = {
>  	{ CCW_DEVICE(0x3832, 0) },
>  	{},
>  };

Acked-by: Cornelia Huck <cohuck@...hat.com>