linux-kernel - Re: [PATCH 2/2] Revert "pstore: Honor dmesg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+2RWmefD+4usyZvNg0k5jnxDJgZw72pSAyXduRjXPRWQ@mail.gmail.com>
Date:   Tue, 15 Aug 2017 12:01:07 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Petr Mladek <pmladek@...e.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Nick Kralevich <nnk@...gle.com>,
        Sebastian Schmidt <yath@...h.de>,
        Tony Luck <tony.luck@...el.com>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Patrick Tjin <pattjin@...gle.com>,
        Mark Salyzyn <salyzyn@...gle.com>
Subject: Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"

On Tue, Aug 15, 2017 at 4:55 AM, Petr Mladek <pmladek@...e.com> wrote:
> On Thu 2017-08-10 13:36:35, Kees Cook wrote:
>> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with
>> various conflict clean-ups.
>>
>> With the default root directory mode set to 0750 now, the capability
>> check was redundant.
>>
>> Suggested-by: Nick Kralevich <nnk@...gle.com>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> The patch looks correct from the code side. I looked at
> it because it touched printk.c. Note that I am not
> security expert.
>
> Reviewed-by: Petr Mladek <pmladek@...e.cz>

Thanks!

-Kees

-- 
Kees Cook
Pixel Security