linux-kernel - Re: [PATCH v7 2/9] mm, swap: Add infrastructure for saving page metadata on swap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170815.215326.1833101229202321710.davem@davemloft.net>
Date:   Tue, 15 Aug 2017 21:53:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     khalid.aziz@...cle.com
Cc:     akpm@...ux-foundation.org, dave.hansen@...ux.intel.com,
        arnd@...db.de, kirill.shutemov@...ux.intel.com, mhocko@...e.com,
        jack@...e.cz, ross.zwisler@...ux.intel.com,
        aneesh.kumar@...ux.vnet.ibm.com, dave.jiang@...el.com,
        willy@...radead.org, hughd@...gle.com, minchan@...nel.org,
        hannes@...xchg.org, hillf.zj@...baba-inc.com, shli@...com,
        mingo@...nel.org, jmarchan@...hat.com, lstoakes@...il.com,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, sparclinux@...r.kernel.org,
        khalid@...ehiking.org
Subject: Re: [PATCH v7 2/9] mm, swap: Add infrastructure for saving page
 metadata on swap

From: Khalid Aziz <khalid.aziz@...cle.com>
Date: Wed,  9 Aug 2017 15:25:55 -0600

> @@ -1399,6 +1399,12 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
>  				(flags & TTU_MIGRATION)) {
>  			swp_entry_t entry;
>  			pte_t swp_pte;
> +
> +			if (arch_unmap_one(mm, vma, address, pteval) < 0) {
> +				set_pte_at(mm, address, pvmw.pte, pteval);
> +				ret = false;
> +				page_vma_mapped_walk_done(&pvmw);
> +				break;
>  			/*
>  			 * Store the pfn of the page in a special migration
>  			 * pte. do_swap_page() will wait until the migration
> @@ -1410,6 +1416,7 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
>  			if (pte_soft_dirty(pteval))
>  				swp_pte = pte_swp_mksoft_dirty(swp_pte);
>  			set_pte_at(mm, address, pvmw.pte, swp_pte);
> +			}

This basic block doesn't look right.  I think the new closing brace is
intended to be right after the new break; statement.  If not at the
very least the indentation of the existing code in there needs to be
adjusted.