linux-kernel - Re: [PATCH 2/2] dmaengine: at_xdmac: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170816061906.c3q52ummmungnweo@rfolt0960.corp.atmel.com>
Date:   Wed, 16 Aug 2017 08:19:06 +0200
From:   Ludovic Desroches <ludovic.desroches@...rochip.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
CC:     <ludovic.desroches@...rochip.com>, <dan.j.williams@...el.com>,
        <vinod.koul@...el.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <dmaengine@...r.kernel.org>
Subject: Re: [PATCH 2/2] dmaengine: at_xdmac: Handle return value of
 clk_prepare_enable.

On Mon, Aug 07, 2017 at 01:15:19PM +0530, Arvind Yadav wrote:
> clk_prepare_enable() can fail here and we must check its return value.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>

Thanks
> ---
>  drivers/dma/at_xdmac.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c
> index 6a3cf97..c00e392 100644
> --- a/drivers/dma/at_xdmac.c
> +++ b/drivers/dma/at_xdmac.c
> @@ -1883,8 +1883,11 @@ static int atmel_xdmac_resume(struct device *dev)
>  	struct at_xdmac_chan	*atchan;
>  	struct dma_chan		*chan, *_chan;
>  	int			i;
> +	int ret;
>  
> -	clk_prepare_enable(atxdmac->clk);
> +	ret = clk_prepare_enable(atxdmac->clk);
> +	if (ret)
> +		return ret;
>  
>  	/* Clear pending interrupts. */
>  	for (i = 0; i < atxdmac->dma.chancnt; i++) {
> -- 
> 1.9.1
>