linux-kernel - Re: [PATCH v2 3/4] staging: pi433: Renaming Enums

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170816073413.b2lll5daflcje2kl@mwanda>
Date:   Wed, 16 Aug 2017 10:34:13 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Rishabh Hardas <rishabhhardas@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, rjosephwright@...il.com,
        linux@...f-Entwicklungen.de, colin.king@...onical.com
Subject: Re: [PATCH v2 3/4] staging: pi433: Renaming Enums

On Wed, Aug 16, 2017 at 10:53:20AM +0530, Rishabh Hardas wrote:
> Remove camel casing by renaming enums.
> 
> Signed-off-by: Rishabh Hardas <rishabhhardas@...il.com>
> ---
>  drivers/staging/pi433/pi433_if.h  | 36 ++++++++++++++++--------------------
>  drivers/staging/pi433/rf69.c      | 26 +++++++++++++-------------
>  drivers/staging/pi433/rf69.h      | 26 +++++++++++++-------------
>  drivers/staging/pi433/rf69_enum.h | 16 ++++++++--------
>  4 files changed, 50 insertions(+), 54 deletions(-)
> 
> diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h
> index 84032f3..2929de0 100644
> --- a/drivers/staging/pi433/pi433_if.h
> +++ b/drivers/staging/pi433/pi433_if.h
> @@ -62,21 +62,20 @@ struct pi433_tx_cfg {
>  	__u16			bit_rate;
>  	__u32			dev_frequency;
>  	enum modulation		modulation;
> -	enum modShaping		modShaping;
> +	enum mod_shaping		modShaping;

Now the names don't line up.

regards,
dan carpenter