linux-kernel - Re: [PATCH] staging: fsl-mc: fix fsl_mc_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170816121014.7bbeipqxxccx7okm@mwanda>
Date:   Wed, 16 Aug 2017 15:10:14 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Colin King <colin.king@...onical.com>
Cc:     devel@...verdev.osuosl.org, Stuart Yoder <stuyoder@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>
Subject: Re: [PATCH] staging: fsl-mc: fix fsl_mc_is_allocatable strcmps

On Wed, Aug 16, 2017 at 03:06:54PM +0300, Dan Carpenter wrote:
> On Wed, Aug 16, 2017 at 12:44:51PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@...onical.com>
> > 
> > The previous fix removed the equal to zero comparisons by the strcmps and
> > now the function always returns true. Fix this by adding in the missing
> > logical negation operators.
> > 
> > Detected by CoverityScan, CID#1452267 ("Constant expression result")
> > 
> > Fixes: b93ad9a067e1 ("staging: fsl-mc: be consistent when checking strcmp() return")
> 
> Ugh...  I did review the original patch at all.  Sorry.

s/did/did not/

regards,
dan carpenter