linux-kernel - Re: [PATCH] crypto: mediatek - Add empty messages check in GCM mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1502887817.30384.16.camel@mtkswgap22>
Date:   Wed, 16 Aug 2017 20:50:17 +0800
From:   Ryder Lee <ryder.lee@...iatek.com>
To:     Stephan Mueller <smueller@...onox.de>
CC:     Herbert Xu <herbert@...dor.apana.org.au>,
        <linux-crypto@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: mediatek - Add empty messages check in GCM mode

Hi,

On Wed, 2017-08-16 at 14:18 +0200, Stephan Mueller wrote:
> Am Mittwoch, 16. August 2017, 13:19:48 CEST schrieb Ryder Lee:
> 
> Hi Ryder,
> 
> > Currently, empty messages are not supported in GCM mode, hence add
> > a check to prevent producing incorrect results.
> 
> In case the caller would provide empty messages, would there be just wrong 
> data or a real problem? Note, unprivileged user space can make such requests.
> 
> If there would be a real problem (like crash), this should also go to stable.
> 
> Ciao
> Stephan

This does not cause any problem and it just returns a wrong result. 

Ryder