linux-kernel - Re: [v7 wlcore: add missing nvs file name info for wilink8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y3qj7gyu.fsf@kamboji.qca.qualcomm.com>
Date:   Wed, 16 Aug 2017 16:57:45 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     "Reizer\, Eyal" <eyalr@...com>
Cc:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        "\,Tony Lindgren" <tony@...mide.com>,
        "linux-wireless\@vger.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        Julian Calaby <julian.calaby@...il.com>
Subject: Re: [v7 wlcore: add missing nvs file name info for wilink8

"Reizer, Eyal" <eyalr@...com> writes:

>> > +		if (wl->fuse_oui_addr == 0 && wl->fuse_nic_addr == 0) {
>> > +			wl1271_warning("Fuse mac address is zero. using "
>> > +					"random mac\n");
>> 
>> This one should also go into one line.
>
> This will still exceed 80 characters. Is this still ok?

Yes, it's ok that the _format string_ goes above 80 chars, but if there
are paremeters you should split them to a separate line. Example:

	pr_debug("This is an example of a very long message which also prints few variables foo %d bar %d",
		 foo, bar);

-- 
Kalle Valo