linux-kernel - [PATCH 1/2] fs-qnx6: Delete an error message for a failed memory allocation in qnx6_mmi_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <888c8fc4-11bb-008b-7396-be4fd2a695a7@users.sourceforge.net>
Date:   Wed, 16 Aug 2017 18:14:52 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Fabian Frederick <fabf@...net.be>,
        Kai Bankett <chaosman@...ika.net>,
        kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 1/2] fs-qnx6: Delete an error message for a failed memory
 allocation in qnx6_mmi_fill_super()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 16 Aug 2017 17:07:26 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/qnx6/super_mmi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/qnx6/super_mmi.c b/fs/qnx6/super_mmi.c
index 62aaf3e3126a..fdcfc99e2db6 100644
--- a/fs/qnx6/super_mmi.c
+++ b/fs/qnx6/super_mmi.c
@@ -100,10 +100,8 @@ struct qnx6_super_block *qnx6_mmi_fill_super(struct super_block *s, int silent)
 	}
 
 	qsb = kmalloc(sizeof(*qsb), GFP_KERNEL);
-	if (!qsb) {
-		pr_err("unable to allocate memory.\n");
+	if (!qsb)
 		goto out;
-	}
 
 	if (fs64_to_cpu(sbi, sb1->sb_serial) >
 					fs64_to_cpu(sbi, sb2->sb_serial)) {
-- 
2.14.0