linux-kernel - Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking strcmp() return"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170816171647.GA27365@kroah.com>
Date:   Wed, 16 Aug 2017 10:16:48 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Stuart Yoder <stuyoder@...il.com>,
        Laurentiu Tudor <laurentiu.tudor@....com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "staging: fsl-mc: be consistent when checking
 strcmp() return"

On Wed, Aug 16, 2017 at 06:12:00PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The previous fix removed the equal to zero comparisons by the strcmps and
> now the function always returns true. Revert this change to restore the
> original correctly functioning code.
> 
> Detected by CoverityScan, CID#1452267 ("Constant expression result")
> 
> This reverts commit b93ad9a067e1515af42da7d56bc61f1a25075f94.

So this should say:
Fixes: XXXXXX

right?

And it should get into 4.13-final, right?  Or if not, at least
backported to 4.13-stable?

Can you please resend it with the fixes tag?

thanks,

greg k-h