linux-kernel - Re: [PATCH v2] completion: Document that reinit_completion() must be called after complete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170816132002.206a38f7@gandalf.local.home>
Date:   Wed, 16 Aug 2017 13:20:02 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v2] completion: Document that reinit_completion() must
 be called after complete_all()

On Wed, 16 Aug 2017 10:18:27 -0700
Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> On Wed, Aug 16, 2017 at 10:12 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> > The function complete_all() modifies the completion "done" variable to
> > UINT_MAX, and no other caller (wait_for_completion(), etc) will modify
> > it back to zero. That means that any call to complete_all() must have a
> > reinit_completion() before that completion can be used again.
> >
> > Document this fact by the complete_all() function.
> >
> > Also document that completion_done() will always return true if
> > complete_all() is called.  
> 
> Ack. Do I take it directly or is it indended for some other tree?
> 
>                Linus

You can take it, if nobody else wants to.

Thanks!

-- Steve