linux-kernel - Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170816.110635.1062040564700704290.davem@davemloft.net>
Date:   Wed, 16 Aug 2017 11:06:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     decui@...rosoft.com
Cc:     netdev@...r.kernel.org, gregkh@...uxfoundation.org,
        devel@...uxdriverproject.org, kys@...rosoft.com,
        haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        georgezhang@...are.com, jhansen@...are.com, mkubecek@...e.cz,
        asias@...hat.com, stefanha@...hat.com, vkuznets@...hat.com,
        cavery@...hat.com, jasowang@...hat.com, rolf.neugebauer@...ker.com,
        dave.scott@...ker.com, marcelo.cerri@...onical.com,
        apw@...onical.com, olaf@...fle.de, joe@...ches.com,
        linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH net-next 1/3] VMCI: only load on VMware hypervisor

From: Dexuan Cui <decui@...rosoft.com>
Date: Tue, 15 Aug 2017 22:13:29 +0000

> +	/*
> +	 * Check if we are running on VMware's hypervisor and bail out
> +	 * if we are not.
> +	 */
> +	if (x86_hyper != &x86_hyper_vmware)
> +		return -ENODEV;

This symbol is only available when CONFIG_HYPERVISOR_GUEST is defined.
But this driver does not have a Kconfig dependency on that symbol so
the build can fail in some configurations.