linux-kernel - Re: [PATCH] auxdisplay: ht16k33: Use generic device properties function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170816183240.GB25491@dtor-ws>
Date:   Wed, 16 Aug 2017 11:32:40 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Robin van der Gracht <robin@...tonic.nl>
Cc:     linux-kernel@...r.kernel.org,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@...il.com>,
        linux-input@...r.kernel.org
Subject: Re: [PATCH] auxdisplay: ht16k33: Use generic device properties
 function

On Wed, Aug 16, 2017 at 12:22:48PM +0200, Robin van der Gracht wrote:
> matrix_keypad_parse_of_params() was replaced early this year.
> 
> Signed-off-by: Robin van der Gracht <robin@...tonic.nl>
> ---
> 
> Early this year Dmitry Torokhov introduced a switch to using generic
> device properties instead of being OF-specific.
> 
> Somehow this driver wasn't included in the update.

It was outside of "input" tree so I did not update directly, so I kept
the old name available. I meant to send a separate patch updating
ht16k33, but I guess I forgot...

FWIW Reviewed-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

I think you want to send it to GregKH as he was picking up the other
ht16k33 patches.

> 
> For reference: https://patchwork.kernel.org/patch/9527095/
> 
>  drivers/auxdisplay/ht16k33.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
> index fbfa5b4cc567..99ce9731fc9c 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -354,7 +354,7 @@ static int ht16k33_keypad_probe(struct i2c_client *client,
>  		return err;
>  	}
>  
> -	err = matrix_keypad_parse_of_params(&client->dev, &rows, &cols);
> +	err = matrix_keypad_parse_properties(&client->dev, &rows, &cols);
>  	if (err)
>  		return err;
>  	if (rows > HT16K33_MATRIX_KEYPAD_MAX_ROWS ||
> -- 
> 2.11.0
> 

Thanks.

-- 
Dmitry