linux-kernel - Re: [PATCH] scsi: cxlflash: Fix an error handling path in 'cxlflash_disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D62EAC69-693C-4231-95F9-B48F47AB241C@linux.vnet.ibm.com>
Date:   Tue, 15 Aug 2017 19:21:31 -0500
From:   "Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     "Manoj N. Kumar" <manoj@...ux.vnet.ibm.com>,
        Uma Krishnan <ukrishn@...ux.vnet.ibm.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] scsi: cxlflash: Fix an error handling path in
 'cxlflash_disk_attach()'

> On Aug 15, 2017, at 3:18 PM, Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:
> 
> 'rc' is known to be 0 at this point.
> If 'create_context()' fails, returns -ENOMEM instead of 0 which means
> success.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Yep, that's a bug.

Acked-by: Matthew R. Ochs <mrochs@...ux.vnet.ibm.com>