linux-kernel - Re: [PATCH] soc: versatile: remove unnecessary static in realview_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK8P3a2pLHdYiRjh6-VEBBTr_4jNi1R_ZO_L_E2RGwnccmQY0g@mail.gmail.com>
Date:   Wed, 16 Aug 2017 22:29:59 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: versatile: remove unnecessary static in realview_soc_probe()

On Wed, Aug 2, 2017 at 1:59 PM, Linus Walleij <linus.walleij@...aro.org> wrote:
> On Thu, Jul 20, 2017 at 12:40 AM, Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>
>> Remove unnecessary static on local variables syscon_regmap.
>> Such variables are initialized before being used, on every
>> execution path throughout the functions. The static has no
>> benefit and, removing it reduces the object file size.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Good catch!

> Acked-by: Linus Walleij <linus.walleij@...aro.org>

Applied to next/cleanup with your Ack, thanks!

     Arnd