linux-kernel - Re: [PATCH v2] watchdog: dw_wdt: fix overflow issue in dw_wdt_top_in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201708170437.bgLIZ7zv%fengguang.wu@intel.com>
Date:   Thu, 17 Aug 2017 04:30:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Huibin Hong <huibin.hong@...k-chips.com>
Cc:     kbuild-all@...org, linux@...ck-us.net, huangtao@...k-chips.com,
        Huibin Hong <huibin.hong@...k-chips.com>,
        Wim Van Sebroeck <wim@...ana.be>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] watchdog: dw_wdt: fix overflow issue in
 dw_wdt_top_in_seconds

Hi Huibin,

[auto build test ERROR on linus/master]
[also build test ERROR on v4.13-rc5 next-20170816]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Huibin-Hong/watchdog-dw_wdt-fix-overflow-issue-in-dw_wdt_top_in_seconds/20170817-033555
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/watchdog/dw_wdt.c: In function 'dw_wdt_top_in_seconds':
>> drivers/watchdog/dw_wdt.c:77:38: error: 'dw_wdt' is a pointer; did you mean to use '->'?
     return (cycles / clk_get_rate(dw_wdt.clk));
                                         ^
                                         ->
   drivers/watchdog/dw_wdt.c:78:1: warning: control reaches end of non-void function [-Wreturn-type]
    }
    ^

vim +77 drivers/watchdog/dw_wdt.c

    68	
    69	static inline int dw_wdt_top_in_seconds(struct dw_wdt *dw_wdt, unsigned top)
    70	{
    71		/*
    72		 * There are 16 possible timeout values in 0..15 where the number of
    73		 * cycles is 2 ^ (16 + i) and the watchdog counts down.
    74		 */
    75		unsigned int cycles = 1 << (16 + top);
    76	
  > 77		return (cycles / clk_get_rate(dw_wdt.clk));
    78	}
    79	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (51272 bytes)