linux-kernel - Re: [PATCH] tun: make tun_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 16 Aug 2017 14:27:52 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     jasowang@...hat.com
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        mst@...hat.com, eric.dumazet@...il.com
Subject: Re: [PATCH] tun: make tun_build_skb() thread safe

From: Jason Wang <jasowang@...hat.com>
Date: Wed, 16 Aug 2017 22:14:33 +0800

> From: Eric Dumazet <eric.dumazet@...il.com>
> 
> tun_build_skb() is not thread safe since it uses per queue page frag,
> this will break things when multiple threads are sending through same
> queue. Switch to use per-thread generator (no lock involved).
> 
> Fixes: 66ccbc9c87c2 ("tap: use build_skb() for small packet")
> Tested-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Jason Wang <jasowang@...hat.com>

Applied, thanks.