linux-kernel - Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170816220805.GA29988@kroah.com>
Date:   Wed, 16 Aug 2017 15:08:05 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Gilad Ben-Yossef <gilad@...yossef.com>
Cc:     linux-crypto@...r.kernel.org,
        driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org, Ofir Drang <ofir.drang@....com>
Subject: Re: [PATCH v3 11/22] staging: ccree: fix line indentation and breaks

On Tue, Aug 15, 2017 at 09:26:39AM +0300, Gilad Ben-Yossef wrote:
> Fix wrong indentation and line breaks, including missing tabs,
> breaking lines longer then 80 char or wrongly broken.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com>
> ---
>  drivers/staging/ccree/ssi_driver.c | 107 +++++++++++++++++++++++--------------
>  1 file changed, 67 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/staging/ccree/ssi_driver.c b/drivers/staging/ccree/ssi_driver.c
> index 81cb63d..0ce2f57 100644
> --- a/drivers/staging/ccree/ssi_driver.c
> +++ b/drivers/staging/ccree/ssi_driver.c
> @@ -87,27 +87,31 @@ void dump_byte_array(const char *name, const u8 *the_array, unsigned long size)
>  
>  	ret = snprintf(line_buf, sizeof(line_buf), "%s[%lu]: ", name, size);
>  	if (ret < 0) {
> -		SSI_LOG_ERR("snprintf returned %d . aborting buffer array dump\n", ret);
> +		SSI_LOG_ERR
> +		    ("snprintf returned %d . aborting buffer array dump\n",
> +		     ret);

As Joe said, this is pretty bad.  Just move "ret);" to the next line,
and then fix it up so that there are not SSI_LOG_ERR() macros and use
the normal in-kernel printing functions instead, then you will not get
this type of warning.

thanks,

greg k-h