linux-kernel - Re: [PATCH] thunderbolt: fix incorrect value assigned to req->response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817093928.GF2327@lahna.fi.intel.com>
Date:   Thu, 17 Aug 2017 12:39:28 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Colin King <colin.king@...onical.com>,
        Andreas Noever <andreas.noever@...il.com>,
        Michael Jamet <michael.jamet@...el.com>,
        Yehezkel Bernat <yehezkel.bernat@...el.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: fix incorrect value assigned to
 req->response_type

On Wed, Aug 16, 2017 at 09:13:27AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Aug 16, 2017 at 11:10:01AM +0300, Mika Westerberg wrote:
> > On Tue, Aug 15, 2017 at 06:22:59PM +0300, Dan Carpenter wrote:
> > > On Tue, Aug 15, 2017 at 05:38:34PM +0300, Mika Westerberg wrote:
> > > > On Tue, Aug 15, 2017 at 03:31:33PM +0100, Colin King wrote:
> > > > > From: Colin Ian King <colin.king@...onical.com>
> > > > > 
> > > > > req->response_type is being assigned the sizeof TB_CFG_PKG_RESET
> > > > > and should actually be assigned TB_CFG_PKG_RESET. Fix this.
> > > > > 
> > > > > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > > > 
> > > > IIRC I already acked this some time ago ;-)
> > > > 
> > > > Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > > > 
> > > > BTW, you should CC Greg as he has been gathering Thunderbolt related
> > > > patches. I added him now.
> > > 
> > > Yeah.  I sent this patch on Jun 14.  "[PATCH] thunderbolt: Fix reset
> > > response_type"  I didn't CC Greg, either.  Someone should probably
> > > update MAINTAINERS if Greg needs to get these emails.
> > 
> > Indeed.
> > 
> > Greg, Andreas,
> > 
> > Should we add Greg to the MAINTAINERS so that he will be getting all the
> > thunderbolt related patches? Another way, if we want to make this easier
> > for Greg, is to establish a thunderbolt tree in kernel.org and send pull
> > requests to him directly.
> 
> The "maintainers" of thunderbolt should either be forwarding on patches
> to me to accept, or to give me a git tree to pull, or to ack patches
> that I am cc:ed on.  Whichever works best for them, but in all cases, I
> am not the maintainer of the thunderbolt subsystem, so I don't need to
> be listed under MAINTAINERS.

OK, thanks for the clarification :)