linux-kernel - Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error status block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25f9878c-932e-e400-ba06-6e61af41bbfd@huawei.com>
Date:   Thu, 17 Aug 2017 18:45:17 +0800
From:   gengdongjiu <gengdongjiu@...wei.com>
To:     Borislav Petkov <bp@...e.de>
CC:     <tbaicar@...eaurora.org>, <james.morse@....com>,
        <geliangtang@...il.com>, <andriy.shevchenko@...ux.intel.com>,
        <tony.luck@...el.com>, <austinwc@...eaurora.org>,
        <rjw@...ysocki.net>, <lenb@...nel.org>,
        <linux-acpi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <john.garry@...wei.com>,
        <shiju.jose@...wei.com>, <zhengqiang10@...wei.com>,
        <wangxiongfeng2@...wei.com>, <huangshaoyu@...wei.com>,
        <wuquanming@...wei.com>
Subject: Re: [PATCH v3] acpi: apei: fix the wrongly iterate generic error
 status block

Borislav,
  thanks for the review,

On 2017/8/17 17:25, Borislav Petkov wrote:
> On Wed, Aug 16, 2017 at 04:14:50PM +0800, Dongjiu Geng wrote:
>> The revision 0x300 generic error data entry is different
>> from the old version, but currently iterating through the
>> GHES estatus blocks does not take into account this difference.
>> This will lead to failure to get the right data entry if GHES
>> has revision 0x300 error data entry.
>>
>> Update the GHES estatus iteration to properly increment using
> 			  iteration macro
> 
>> acpi_hest_get_next, and correct the iteration termination condition
> Please end function names with parentheses.
> 
>> because the status block data length only includes error data length.
> <---- newline here.
> 
>> Clear the CPER estatus printing iteration logic to use same macro.
> s/Clear ... /Convert ... to the same macro./
> 
>> Signed-off-by: Dongjiu Geng <gengdongjiu@...wei.com>
>> CC: Tyler Baicar <tbaicar@...eaurora.org>
>> ---
>>  drivers/acpi/apei/apei-internal.h |  5 -----
>>  drivers/firmware/efi/cper.c       | 12 ++----------
>>  include/acpi/ghes.h               |  5 +++++
>>  3 files changed, 7 insertions(+), 15 deletions(-)
> With those addressed you can add:
  Ok, I will add.

> 
> Reviewed-by: Borislav Petkov <bp@...e.de>
> 
> --