linux-kernel - Re: [PATCH v2 2/5] KVM: MMU: check guest CR3 reserved bits based on its physical address width.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28276aa5-76e5-1826-5b1f-e18a62cd903d@redhat.com>
Date:   Thu, 17 Aug 2017 14:31:11 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Yu Zhang <yu.c.zhang@...ux.intel.com>, kvm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, rkrcmar@...hat.com,
        tglx@...utronix.de, mingo@...hat.com, hpa@...or.com,
        xiaoguangrong@...cent.com, joro@...tes.org
Subject: Re: [PATCH v2 2/5] KVM: MMU: check guest CR3 reserved bits based on
 its physical address width.

On 17/08/2017 21:52, Yu Zhang wrote:
> +		if (efer & EFER_LMA) {
> +			u64 maxphyaddr;
> +			u32 eax = 0x80000008;
> +
> +			if (ctxt->ops->get_cpuid(ctxt, &eax, NULL, NULL, NULL,
> +						 NO_CHECK_LIMIT)) {
> +				maxphyaddr = eax & 0xff;
> +				rsvd = rsvd_bits(maxphyaddr, 62);
> +			}

You should use 36 here if ctxt->ops->get_cpuid returns false, for
consistency with cpuid_query_maxphyaddr.

Paolo