linux-kernel - Re: [PATCH] ARM: imx_v6_v7_defconfig: Add CONFIG_FW_LOADER_USER_HELPER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817141243.GG7608@dragon>
Date:   Thu, 17 Aug 2017 22:12:45 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Gary Bisson <gary.bisson@...ndarydevices.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Cc:     kernel@...gutronix.de, fabio.estevam@....com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Add
 CONFIG_FW_LOADER_USER_HELPER_FALLBACK

On Thu, Aug 17, 2017 at 04:04:24PM +0200, Gary Bisson wrote:
> Allows to load firmware files which aren't built inside the kernel.
> 
> Especially useful for CODA firmware (vpu_fw_imx6q.bin) which is usually
> located in the rootfs.
> 
> Signed-off-by: Gary Bisson <gary.bisson@...ndarydevices.com>
> ---
> Hi Shawn,
> 
> I'm not sure if this patch is acceptable since I've noticed that no
> configuration currently has that option enabled (why?).
> 
> As mentioned in the commit, I had to enable that in order to have CODA
> load the VPU firmware properly.
> 
> Another option would be to make the CODA driver a module...
> 
> Let me know your thoughts.

@Philipp, do you have any comments on this?

>From reading of the option help text, I feel the option is not
recommended?

config FW_LOADER_USER_HELPER_FALLBACK

This option enables / disables the invocation of user-helper
(e.g. udev) for loading firmware files as a fallback after the
direct file loading in kernel fails.  The user-mode helper is
no longer required unless you have a special firmware file that
resides in a non-standard path. Moreover, the udev support has
been deprecated upstream.

Shawn