linux-kernel - Re: [PATCH net] PCI: fix the return value for the pci_find_pcie_root

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170816.194235.391501463422735735.davem@davemloft.net>
Date:   Wed, 16 Aug 2017 19:42:35 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     dingtianhong@...wei.com
Cc:     leedom@...lsio.com, ashok.raj@...el.com, bhelgaas@...gle.com,
        helgaas@...nel.org, werner@...lsio.com, ganeshgr@...lsio.com,
        asit.k.mallick@...el.com, patrick.j.cramer@...el.com,
        Suravee.Suthikulpanit@....com, Bob.Shaw@....com,
        l.stach@...gutronix.de, amira@...lanox.com,
        gabriele.paoloni@...wei.com, David.Laight@...lab.com,
        jeffrey.t.kirsher@...el.com, catalin.marinas@....com,
        will.deacon@....com, mark.rutland@....com, robin.murphy@....com,
        alexander.duyck@...il.com, eric.dumazet@...il.com,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com, thierry.reding@...il.com
Subject: Re: [PATCH net] PCI: fix the return value for the
 pci_find_pcie_root_port()

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Thu, 17 Aug 2017 10:25:30 +0800

> The pci_find_pcie_root_port() would return NULL if the given
> dev is already a Root Port, it looks like unfriendly to the
> PCIe Root Port device, Thierry and Bjorn suggest to let this
> function return the given dev under this circumstances.
> 
> Fixes: 0e405232871d6 ("PCI: fix oops when try to find Root Port for a PCI device")
> Suggested-by: Thierry Reding <thierry.reding@...il.com>
> Suggested-by: Bjorn Helgaas <helgaas@...nel.org>
> Signed-off-by: Thierry Reding <thierry.reding@...il.com>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Bjorn, please review and ACK so Linus doesn't rip my head off again
:-)

Thanks.