linux-kernel - Re: [PATCH v4 2/4] dt-bindings: can: can-transceiver: Document new binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817151036.jyvg63oyhkne5jsg@rob-hp-laptop>
Date:   Thu, 17 Aug 2017 10:10:36 -0500
From:   Rob Herring <robh@...nel.org>
To:     Franklin S Cooper Jr <fcooper@...com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        netdev@...r.kernel.org, linux-can@...r.kernel.org,
        wg@...ndegger.com, mkl@...gutronix.de,
        quentin.schulz@...e-electrons.com, dev.kurt@...dijck-laurijssen.be,
        andrew@...n.ch, sergei.shtylyov@...entembedded.com,
        socketcan@...tkopp.net
Subject: Re: [PATCH v4 2/4] dt-bindings: can: can-transceiver: Document new
 binding

On Wed, Aug 09, 2017 at 07:59:14PM -0500, Franklin S Cooper Jr wrote:
> Add documentation to describe usage of the new can-transceiver binding.
> This new binding is applicable for any CAN device therefore it exists as
> its own document.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@...com>
> ---
> Version 4 changes:
> Drop unit address.
> Switch from using fixed-transceiver to can-transceiver
> 
>  .../bindings/net/can/can-transceiver.txt           | 24 ++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/can/can-transceiver.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/can/can-transceiver.txt b/Documentation/devicetree/bindings/net/can/can-transceiver.txt
> new file mode 100644
> index 0000000..2c31dc0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/can-transceiver.txt
> @@ -0,0 +1,24 @@
> +Generic CAN transceiver Device Tree binding
> +------------------------------
> +
> +CAN transceiver typically limits the max speed in standard CAN and CAN FD
> +modes. Typically these limitations are static and the transceivers themselves
> +provide no way to detect this limitation at runtime. For this situation,
> +the "can-transceiver" node can be used.
> +
> +Required Properties:
> + max-bitrate:	a positive non 0 value that determines the max
> +		speed that CAN/CAN-FD can run. Any other value
> +		will be ignored.
> +
> +Examples:
> +
> +Based on Texas Instrument's TCAN1042HGV CAN Transceiver
> +
> +m_can0 {
> +	....
> +	can-transceiver@ {

Need to drop the @ too. With that,

Acked-by: Rob Herring <robh@...nel.org>


> +		max-bitrate = <5000000>;
> +	};
> +	...
> +};
> -- 
> 2.9.4.dirty
>