linux-kernel - Re: [PATCH] dax: explain how read(2)/write(2) addresses are validated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170817152054.GA27641@linux.intel.com>
Date:   Thu, 17 Aug 2017 09:20:54 -0600
From:   Ross Zwisler <ross.zwisler@...ux.intel.com>
To:     Jan Kara <jack@...e.cz>
Cc:     Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christoph Hellwig <hch@....de>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Chinner <david@...morbit.com>,
        Matthew Wilcox <mawilcox@...rosoft.com>,
        linux-fsdevel@...r.kernel.org, linux-nvdimm@...ts.01.org,
        Kees Cook <keescook@...omium.org>,
        Will Deacon <will.deacon@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Robin Murphy <robin.murphy@....com>,
        Mark Rutland <mark.rutland@....com>
Subject: Re: [PATCH] dax: explain how read(2)/write(2) addresses are validated

On Thu, Aug 17, 2017 at 10:53:32AM +0200, Jan Kara wrote:
> On Wed 16-08-17 11:36:15, Ross Zwisler wrote:
> > Add a comment explaining how the user addresses provided to read(2) and
> > write(2) are validated in the DAX I/O path.  We call dax_copy_from_iter()
> > or copy_to_iter() on these without calling access_ok() first in the DAX
> > code, and there was a concern that the user might be able to read/write to
> > arbitrary kernel addresses with this path.
> > 
> > Signed-off-by: Ross Zwisler <ross.zwisler@...ux.intel.com>
> 
> Looks OK to me so feel free to add:
> 
> Reviewed-by: Jan Kara <jack@...e.cz>
> 
> Just I'd note that standard buffered read / write path is no different so I
> don't see a big point in adding this comment when it is not in any other
> path either...

Fair enough.  Yea, if it's not in any of the other paths either and it's just
common knowledge that these addresses are validated at the VFS layer, we can
leave it out.