linux-kernel - Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817162957.fes3tu64onuiqspe@ninjato>
Date:   Thu, 17 Aug 2017 18:29:57 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Colin King <colin.king@...onical.com>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     linux-i2c@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH][i2c-next] i2c-cht-wc: make cht_wc_i2c_adap_driver static

On Wed, Aug 16, 2017 at 10:16:59AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The structure cht_wc_i2c_adap_driver is local to the source
> and does not need to be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'cht_wc_i2c_adap_driver' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

CCing Hans to ask him if he maybe wants to create a MAINTAINERS entry
for this driver, so he'll get CCed for such patches? :)

> ---
>  drivers/i2c/busses/i2c-cht-wc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index fe5caf70c7fe..01c94c918d4c 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -322,7 +322,7 @@ static struct platform_device_id cht_wc_i2c_adap_id_table[] = {
>  };
>  MODULE_DEVICE_TABLE(platform, cht_wc_i2c_adap_id_table);
>  
> -struct platform_driver cht_wc_i2c_adap_driver = {
> +static struct platform_driver cht_wc_i2c_adap_driver = {
>  	.probe = cht_wc_i2c_adap_i2c_probe,
>  	.remove = cht_wc_i2c_adap_i2c_remove,
>  	.driver = {
> -- 
> 2.11.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)