linux-kernel - Re: [PATCH] kernfs: Clarify lockdep name for kn->count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170817184612.GA491396@devbig577.frc2.facebook.com>
Date:   Thu, 17 Aug 2017 11:46:13 -0700
From:   Tejun Heo <tj@...nel.org>
To:     Waiman Long <longman@...hat.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernfs: Clarify lockdep name for kn->count

On Thu, Aug 17, 2017 at 11:49:56AM -0400, Waiman Long wrote:
> The reference count in kernfs_node structure is treated like a rwsem by
> using lockdep instrumentation code. The lockdep name, however, is still
> "s_active" which is carried over from the old sysfs code. As s_active
> is no longer the variable name, its use may confuse users on where the
> lock is when it is reported by lockdep. So it is changed to "kn->count"
> which is how this variable is normally referenced in kernfs code.
> 
> Signed-off-by: Waiman Long <longman@...hat.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun