linux-kernel - Re: [ANNOUNCE] 4.1.42-rt50

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817185327.GH8384@jcartwri.amer.corp.natinst.com>
Date:   Thu, 17 Aug 2017 13:53:27 -0500
From:   Julia Cartwright <julia@...com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:     <linux-kernel@...r.kernel.org>, <linux-rt-users@...r.kernel.org>,
        "Thomas Gleixner" <tglx@...utronix.de>,
        Carsten Emde <C.Emde@...dl.org>,
        John Kacur <jkacur@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [ANNOUNCE] 4.1.42-rt50

On Thu, Aug 17, 2017 at 09:30:28AM +0200, Sebastian Andrzej Siewior wrote:
> On 2017-08-16 15:42:28 [-0500], Julia Cartwright wrote:
[..]
> > diff --git a/kernel/cpu_pm.c b/kernel/cpu_pm.c
> > index 9656a3c36503..9da42f83ee03 100644
> > --- a/kernel/cpu_pm.c
> > +++ b/kernel/cpu_pm.c
> > @@ -22,14 +22,13 @@
> >  #include <linux/spinlock.h>
> >  #include <linux/syscore_ops.h>
> >  
> > -static DEFINE_RWLOCK(cpu_pm_notifier_lock);
> > -static RAW_NOTIFIER_HEAD(cpu_pm_notifier_chain);
> > +static ATOMIC_NOTIFIER_HEAD(cpu_pm_notifier_chain);
> >  
> >  static int cpu_pm_notify(enum cpu_pm_event event, int nr_to_call, int *nr_calls)
> >  {
> >  	int ret;
> >  
> > -	ret = __raw_notifier_call_chain(&cpu_pm_notifier_chain, event, NULL,
> > +	ret = __atomic_notifier_call_chain(&cpu_pm_notifier_chain, event, NULL,
> >  		nr_to_call, nr_calls);
> 
> there is a piece missing, upstream has a different change queued. I know
> that this is the same as in latest RT, this is just to let you know in
> case someone complains about an RCU backtrace???

Ah!  Thanks. Indeed.  I did see the upstream-queued version get cc'd to
linux-rt-users, but didn't see the rcu_irq_{enter,exit}_irqson()
addition, assuming it to be what landed in rt-devel.

Will you be fixing this up in 4.11-rt?

   Julia