linux-kernel - Re: [PATCH] ARM: imx_v6_v7_defconfig: Add CONFIG_FW_LOADER_USER_HELPER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1503043012.7730.5.camel@pengutronix.de>
Date:   Fri, 18 Aug 2017 09:56:52 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Shawn Guo <shawnguo@...nel.org>,
        Gary Bisson <gary.bisson@...ndarydevices.com>
Cc:     kernel@...gutronix.de, fabio.estevam@....com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: imx_v6_v7_defconfig: Add
 CONFIG_FW_LOADER_USER_HELPER_FALLBACK

Hi Shawn,

On Thu, 2017-08-17 at 22:12 +0800, Shawn Guo wrote:
> On Thu, Aug 17, 2017 at 04:04:24PM +0200, Gary Bisson wrote:
> > Allows to load firmware files which aren't built inside the kernel.
> > 
> > Especially useful for CODA firmware (vpu_fw_imx6q.bin) which is
> > usually
> > located in the rootfs.
> > 
> > Signed-off-by: Gary Bisson <gary.bisson@...ndarydevices.com>
> > ---
> > Hi Shawn,
> > 
> > I'm not sure if this patch is acceptable since I've noticed that no
> > configuration currently has that option enabled (why?).
> > 
> > As mentioned in the commit, I had to enable that in order to have
> > CODA
> > load the VPU firmware properly.
> > 
> > Another option would be to make the CODA driver a module...
> > 
> > Let me know your thoughts.
> 
> @Philipp, do you have any comments on this?
> 
> From reading of the option help text, I feel the option is not
> recommended?
> 
> config FW_LOADER_USER_HELPER_FALLBACK
> 
> This option enables / disables the invocation of user-helper
> (e.g. udev) for loading firmware files as a fallback after the
> direct file loading in kernel fails.  The user-mode helper is
> no longer required unless you have a special firmware file that
> resides in a non-standard path. Moreover, the udev support has
> been deprecated upstream.
> 
> Shawn

Building coda as a module should work fine, so I'd say this is not
necessary.

regards
Philipp