linux-kernel - Re: [PATCH] arm64: dts: ls1088a: Add USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170818080355.GK7608@dragon>
Date:   Fri, 18 Aug 2017 16:03:57 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     Yinbo Zhu <yinbo.zhu@....com>
Cc:     Mark Rutland <mark.rutland@....com>,
        Harninder Rai <harninder.rai@....com>,
        Andy Tang <andy.tang@....com>,
        "open list:" <devicetree@...r.kernel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Ashish Kumar <ashish.kumar@....com>,
        open list <linux-kernel@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "linux-devel@...rge.freescale.net" <linux-devel@...rge.freescale.net>,
        Raghav Dogra <raghav.dogra@....com>,
        "moderated list:" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support

On Fri, Aug 18, 2017 at 07:48:19AM +0000, Yinbo Zhu wrote:
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > index 3a3be87..0dbff29 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi
> > @@ -458,6 +458,24 @@
> >  			status = "disabled";
> >  		};
> >  
> > +		usb0: usb3@...0000 {
> > +			compatible = "snps,dwc3";
> > +			reg = <0x0 0x3100000 0x0 0x10000>;
> > +			interrupts = <0 80 0x4>; /* Level high type */
> 
> Use IRQ_TYPE_LEVEL_HIGH, so that you can save the comment.
> 
> > +			dr_mode = "host";
> > +			configure-gfladj;
> 
> What is this?  I do not see it in upstream kernel.
> 
> > +			snps,dis_rxdet_inp3_quirk;
> 
> You probably need a "disabled" status.
> 
> Shawn
> 
> Hi Shawn,
> 
>  About your description " You probably need a "disabled" status."
>  Your meaning is that remove the property "snps,dis_rxdet_inp3_quirk;", isn't it?
>  In fact, if remove the property , 1088ardb usb will doesn't detect.

No, that's not what I meant.  I meant the USB device should be disabled
by default in <soc>.dtsi by having the following line.

	status = "disabled";

And then if your board has the pin-out of this USB device, you have the
line below to turn on the support.

	status = "okay";

Shawn