linux-kernel - [tip:irq/core] genirq: Restrict effective affinity to interrupts actually using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-74def747bcd09692bdbf8c6a15350795b0f11ca8@git.kernel.org>
Date:   Fri, 18 Aug 2017 01:57:42 -0700
From:   tip-bot for Marc Zyngier <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     paul.burton@...tec.com, james.hogan@...tec.com, mingo@...nel.org,
        hpa@...or.com, matt.redfearn@...tec.com,
        gregory.clement@...e-electrons.com, linux-kernel@...r.kernel.org,
        marc.zyngier@....com, f.fainelli@...il.com, jason@...edaemon.net,
        sebastian.hesselbarth@...il.com, tglx@...utronix.de,
        cernekee@...il.com, chris@...kel.net, jcmvbkbc@...il.com,
        andrew@...n.ch, xuwei5@...ilicon.com
Subject: [tip:irq/core] genirq: Restrict effective affinity to interrupts
 actually using it

Commit-ID:  74def747bcd09692bdbf8c6a15350795b0f11ca8
Gitweb:     http://git.kernel.org/tip/74def747bcd09692bdbf8c6a15350795b0f11ca8
Author:     Marc Zyngier <marc.zyngier@....com>
AuthorDate: Fri, 18 Aug 2017 09:39:14 +0100
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Fri, 18 Aug 2017 10:54:39 +0200

genirq: Restrict effective affinity to interrupts actually using it

Just because CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK is selected
doesn't mean that all the interrupts are using the effective
affinity mask. For a number of them, this mask is likely to
be empty.

In order to deal with this, let's restrict the use of the
effective affinity mask to these interrupts that have a non empty
effective affinity.

Signed-off-by: Marc Zyngier <marc.zyngier@....com>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Cc: Andrew Lunn <andrew@...n.ch>
Cc: James Hogan <james.hogan@...tec.com>
Cc: Jason Cooper <jason@...edaemon.net>
Cc: Paul Burton <paul.burton@...tec.com>
Cc: Chris Zankel <chris@...kel.net>
Cc: Kevin Cernekee <cernekee@...il.com>
Cc: Wei Xu <xuwei5@...ilicon.com>
Cc: Max Filippov <jcmvbkbc@...il.com>
Cc: Florian Fainelli <f.fainelli@...il.com>
Cc: Gregory Clement <gregory.clement@...e-electrons.com>
Cc: Matt Redfearn <matt.redfearn@...tec.com>
Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
Link: http://lkml.kernel.org/r/20170818083925.10108-2-marc.zyngier@arm.com

---
 include/linux/irq.h | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/include/linux/irq.h b/include/linux/irq.h
index d2d54379..dcfac6c 100644
--- a/include/linux/irq.h
+++ b/include/linux/irq.h
@@ -781,7 +781,10 @@ static inline struct cpumask *irq_data_get_affinity_mask(struct irq_data *d)
 static inline
 struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d)
 {
-	return d->common->effective_affinity;
+	if (!cpumask_empty(d->common->effective_affinity))
+		return d->common->effective_affinity;
+
+	return d->common->affinity;
 }
 static inline void irq_data_update_effective_affinity(struct irq_data *d,
 						      const struct cpumask *m)