linux-kernel - Re: [PATCH v5 1/1] usb:host:xhci support option to disable the xHCI USB2 HW LPM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5996CAA7.2050304@linux.intel.com>
Date:   Fri, 18 Aug 2017 14:08:23 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     "Thang Q. Nguyen" <tqnguyen@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Mathias Nyman <mathias.nyman@...el.com>,
        linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Phong Vo <pvo@....com>, Loc Ho <lho@....com>,
        Tung Nguyen <tunguyen@....com>, patches <patches@....com>,
        Iyappan Subramanian <isubramanian@....com>
Subject: Re: [PATCH v5 1/1] usb:host:xhci support option to disable the xHCI
 USB2 HW LPM

On 17.08.2017 06:19, Thang Q. Nguyen wrote:
> On Tue, Aug 8, 2017 at 11:27 AM, Thang Q. Nguyen <tqnguyen@....com> wrote:
>> XHCI specification 1.1 does not require xHCI-compliant controllers
>> to always enable hardware USB2 LPM. However, the current xHCI
>> driver always enable it when seeing HLC=1.
>> This patch supports an option for users to control disabling
>> USB2 Hardware LPM via DT/ACPI attribute.
>> This option is needed in case user would like to disable this
>> feature. For example, their xHCI controller has its USB2 HW LPM
>> broken.
>>
>> Signed-off-by: Tung Nguyen <tunguyen@....com>
>> Signed-off-by: Thang Q. Nguyen <tqnguyen@....com>
>> Acked-by: Rob Herring <robh@...nel.org>
>> ---
...
>>
>
> Do you have any comments about this patch? Thanks.
> --

Looks good,
will send forward after 4.14-rc1

Thanks
Mathias