linux-kernel - Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170818114544.szfxl5pbul7gwgxg@sirena.org.uk>
Date:   Fri, 18 Aug 2017 12:45:44 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Jeffy Chen <jeffy.chen@...k-chips.com>
Cc:     linux-kernel@...r.kernel.org, dgreid@...omium.org, heiko@...ech.de,
        briannorris@...omium.org, mka@...omium.org, dianders@...omium.org,
        Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        Oder Chiou <oder_chiou@...ltek.com>,
        Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Bard Liao <bardliao@...ltek.com>
Subject: Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote:
> Currently we are using devm_snd_soc_register_component, which would
> use legacy dai naming when dai drv id is zero.
> 
> Set a non-zero dai drv id to use dai drv name for dai name.

Why?  This is clearly not good, we shouldn't be expecting all devices
with a single DAI to set the DAI number to 1 and the changelog doesn't
articulate any reason why anything cares what the name is.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)