lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Aug 2017 15:29:53 +0300 From: Andy Shevchenko <andy.shevchenko@...il.com> To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com> Cc: "x86@...nel.org" <x86@...nel.org>, Ingo Molnar <mingo@...hat.com>, Zha Qipeng <qipeng.zha@...el.com>, "H. Peter Anvin" <hpa@...or.com>, "dvhart@...radead.org" <dvhart@...radead.org>, Thomas Gleixner <tglx@...utronix.de>, Andy Shevchenko <andy@...radead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Platform Driver <platform-driver-x86@...r.kernel.org>, Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@...il.com> Subject: Re: [RFC v1 3/6] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices On Tue, Aug 1, 2017 at 9:13 PM, <sathyanarayanan.kuppuswamy@...ux.intel.com> wrote: > Currently, we have lot of repetitive code in dependent device resource > allocation and device creation handling code. This logic can be improved if > we use MFD framework for dependent device creation. This patch adds this > support. > +static int ipc_create_pmc_devices(struct platform_device *pdev) > { > - int ret; > - > - /* If we have ACPI based watchdog use that instead */ > + u8 n = 0; > + struct mfd_cell *pmc_mfd_cells; > + > + pmc_mfd_cells = devm_kzalloc(&pdev->dev, > + (sizeof(*pmc_mfd_cells) * PMC_IPC_MAX_MFD_BLOCK), > + GFP_KERNEL); > + if (!pmc_mfd_cells) > + return -ENOMEM; > + > + /* Create PUNIT IPC MFD cell */ > + pmc_mfd_cells[n].name = PUNIT_DEVICE_NAME; > + pmc_mfd_cells[n].id = -1; > + pmc_mfd_cells[n].num_resources = ARRAY_SIZE(punit_ipc_resources); > + pmc_mfd_cells[n].resources = punit_ipc_resources; > + pmc_mfd_cells[n].ignore_resource_conflicts = 1; Please, use static variables instead of allocated on a heap. > + n++; > + > + /* If we have ACPI based watchdog use that instead, othewise create > + * a MFD cell for iTCO watchdog*/ > if (!acpi_has_watchdog()) { > + pmc_mfd_cells[n].name = TCO_DEVICE_NAME; > + pmc_mfd_cells[n].id = -1; > + pmc_mfd_cells[n].platform_data = &tco_info; > + pmc_mfd_cells[n].pdata_size = sizeof(tco_info); > + pmc_mfd_cells[n].num_resources = > + ARRAY_SIZE(watchdog_ipc_resources); > + pmc_mfd_cells[n].resources = watchdog_ipc_resources; > + pmc_mfd_cells[n].ignore_resource_conflicts = 1; > + n++; > } ...and here you do mfd_add_devices() instead of this stuff. Check how lpc_ich.c designed. -- With Best Regards, Andy Shevchenko
Powered by blists - more mailing lists