linux-kernel - Re: [PATCH] arm64: dts: ls1088a: Add USB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170818130224.GN7608@dragon>
Date:   Fri, 18 Aug 2017 21:02:25 +0800
From:   Shawn Guo <shawnguo@...nel.org>
To:     yinbo.zhu@....com
Cc:     linux-devel@...rge.freescale.net, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Harninder Rai <harninder.rai@....com>,
        Ashish Kumar <ashish.kumar@....com>,
        Yuantian Tang <andy.tang@....com>,
        "open list:" <devicetree@...r.kernel.org>,
        "moderated list:" <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: ls1088a: Add USB support

On Fri, Aug 18, 2017 at 04:14:45PM +0800, yinbo.zhu@....com wrote:
> From: "yinbo.zhu" <yinbo.zhu@....com>
> 
> Fix the issue that usb is not detected on ls1088ardb
> 
> Signed-off-by: yinbo.zhu <yinbo.zhu@....com>
> Signed-off-by: Ran Wang <ran.wang_1@....com>

You are sending an updated patch.  Please have the version number in
subject prefix ...

> ---

... and a change history here.  There are a lot of good examples on the
list.  Please have a check.

>  arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts |  8 ++++++++
>  arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi    | 20 ++++++++++++++++++++
>  2 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> index 213abb7..6c3c3bc 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a-rdb.dts
> @@ -118,6 +118,14 @@
>  	status = "okay";
>  };
>  
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
>  &esdhc {
>  	status = "okay";
>  };

I had already put this on previous version - please sort these labelled
nodes alphabetically.  That said, &usb should go after &sata.

Shawn