linux-kernel - [PATCH 3.16 008/134] perf hists browser: Fix typo in function switch_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1503062000.662057862@decadent.org.uk>
Date:   Fri, 18 Aug 2017 14:13:20 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org,
        "Arnaldo Carvalho de Melo" <acme@...hat.com>,
        "Feng Tang" <feng.tang@...el.com>,
        "Changbin Du" <changbin.du@...el.com>,
        "Peter Zijlstra" <peterz@...radead.org>
Subject: [PATCH 3.16 008/134] perf hists browser: Fix typo in function
 switch_data_file

3.16.47-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Changbin Du <changbin.du@...el.com>

commit 3ef5b4023c64c16c793a066a7a2ed6ea3767e0d7 upstream.

Should clear buf 'abs_path', not 'options'.

Signed-off-by: Changbin Du <changbin.du@...el.com>
Cc: Feng Tang <feng.tang@...el.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Fixes: 341487ab561f ("perf hists browser: Add option for runtime switching perf data file")
Link: http://lkml.kernel.org/r/20170313114652.9207-1-changbin.du@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 tools/perf/ui/browsers/hists.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1305,7 +1305,7 @@ static int switch_data_file(void)
 		return ret;
 
 	memset(options, 0, sizeof(options));
-	memset(options, 0, sizeof(abs_path));
+	memset(abs_path, 0, sizeof(abs_path));
 
 	while ((dent = readdir(pwd_dir))) {
 		char path[PATH_MAX];