linux-kernel - Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Aug 2017 11:17:40 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Taeung Song <treeze.taeung@...il.com>
Cc:     linux-kernel@...r.kernel.org, taeung@...slab.kr,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>
Subject: Re: [PATCH v3 4/5] perf annotate browser: Support --show-nr-samples
 option

Em Fri, Aug 18, 2017 at 05:47:03PM +0900, Taeung Song escreveu:
> Cc: Namhyung Kim <namhyung@...nel.org>
> Cc: Jiri Olsa <jolsa@...hat.com>
> Signed-off-by: Taeung Song <treeze.taeung@...il.com>

Ok, now that check for !--stdio is lifted and replaced with:

-       if (symbol_conf.show_nr_samples && !annotate.use_stdio) {
-               pr_err("--show-nr-samples is only available in --stdio mode at this time\n");
+       if (symbol_conf.show_nr_samples && annotate.use_gtk) {
+               pr_err("--show-nr-samples is not available in --gtk mode at this time\n");
                return ret;
        }

- Arnaldo