linux-kernel - Re: [PATCH 1/3] firmware: dcdbas: constify attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Aug 2017 15:36:27 +0100
From:   Ard Biesheuvel <ard.biesheuvel@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Douglas_Warzecha@...l.com, Matt Fleming <matt@...eblueprint.co.uk>,
        Ingo Molnar <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>
Subject: Re: [PATCH 1/3] firmware: dcdbas: constify attribute_group structures.

On 3 August 2017 at 14:37, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> attribute_group are not supposed to change at runtime. All functions
> working with attribute_group provided by <linux/sysfs.h> work with
> const attribute_group. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> ---
>  drivers/firmware/dcdbas.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/dcdbas.c b/drivers/firmware/dcdbas.c
> index 2fe1a13..c16600f 100644
> --- a/drivers/firmware/dcdbas.c
> +++ b/drivers/firmware/dcdbas.c
> @@ -534,7 +534,7 @@ static int dcdbas_reboot_notify(struct notifier_block *nb, unsigned long code,
>         NULL
>  };
>
> -static struct attribute_group dcdbas_attr_group = {
> +static const struct attribute_group dcdbas_attr_group = {
>         .attrs = dcdbas_dev_attrs,
>         .bin_attrs = dcdbas_bin_attrs,
>  };

If Douglas doesn't mind, I will take this trough the EFI tree