linux-kernel - Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1503071631.44656.4.camel@primarydata.com>
Date:   Fri, 18 Aug 2017 15:53:53 +0000
From:   Trond Myklebust <trondmy@...marydata.com>
To:     "colin.king@...onical.com" <colin.king@...onical.com>,
        "bfields@...ldses.org" <bfields@...ldses.org>, hch <hch@....de>,
        "linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
        "jlayton@...chiereds.net" <jlayton@...chiereds.net>,
        "elfring@...rs.sourceforge.net" <elfring@...rs.sourceforge.net>,
        "bcodding redhat" <bcodding@...hat.com>,
        "anna.schumaker@...app.com" <anna.schumaker@...app.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 2/2] lockd: Adjust 61 checks for null pointers

On Thu, 2017-08-17 at 16:34 +0200, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Thu, 17 Aug 2017 16:00:18 +0200
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> The script “checkpatch.pl” pointed information out like the
> following.
> 
> Comparison to NULL could be written …
> 
> Thus fix the affected source code places.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  fs/lockd/clnt4xdr.c | 12 ++++++------
>  fs/lockd/clntlock.c | 10 +++++-----
>  fs/lockd/clntproc.c | 12 ++++++------
>  fs/lockd/clntxdr.c  | 12 ++++++------
>  fs/lockd/host.c     | 22 +++++++++++-----------
>  fs/lockd/mon.c      | 16 ++++++++--------
>  fs/lockd/svc.c      |  4 ++--
>  fs/lockd/svc4proc.c |  6 +++---
>  fs/lockd/svclock.c  | 14 +++++++-------
>  fs/lockd/svcproc.c  |  6 +++---
>  fs/lockd/svcshare.c |  2 +-
>  fs/lockd/svcsubs.c  |  3 +--
>  12 files changed, 59 insertions(+), 60 deletions(-)
> 
> diff --git a/fs/lockd/clnt4xdr.c b/fs/lockd/clnt4xdr.c
> index c349fc0f9b80..ec6473d194fd 100644
> --- a/fs/lockd/clnt4xdr.c
> +++ b/fs/lockd/clnt4xdr.c
> @@ -131,7 +131,7 @@ static int decode_netobj(struct xdr_stream *xdr,
>  	__be32 *p;
>  
>  	p = xdr_inline_decode(xdr, 4);
> -	if (unlikely(p == NULL))
> +	if (unlikely(!p))

Oh STOP with the checkpatch wankfest!

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@...marydata.com