linux-kernel - Re: [PATCH] video: fbdev: constify copied structures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <7127868.v7Fj1TocLv@amdc3058>
Date:   Fri, 18 Aug 2017 19:41:16 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Julia Lawall <Julia.Lawall@...6.fr>
Cc:     kernel-janitors@...r.kernel.org,
        Michal Simek <michal.simek@...inx.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        linux-fbdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: constify copied structures


Hi,

On Wednesday, August 02, 2017 11:04:39 AM Julia Lawall wrote:
> Make const some structures that are only copied into other structures.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

fb_fix_screeninfo and fb_var_screeninfo structures were already
const-ified by commit 40445365a43f ("video: xilinxfb: constify
fb_fix_screeninfo and fb_var_screeninfo structures") in my -next
tree (git://github.com/bzolnier/linux.git fbdev-for-next) so
I just applied xilinx_fb_default_pdata part (patch included below
for reference).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics


From: Julia Lawall <Julia.Lawall@...6.fr>
Subject: [PATCH] video: fbdev: xilinxfb: constify copied structure

Make const xilinx_fb_default_pdata structure that is only copied into
other structure.

Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
Cc: Michal Simek <michal.simek@...inx.com>
Cc: Soren Brinkmann <soren.brinkmann@...inx.com>,
[b.zolnierkie: split from a bigger patch]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
---
 drivers/video/fbdev/xilinxfb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/video/fbdev/xilinxfb.c
===================================================================
--- a/drivers/video/fbdev/xilinxfb.c	2017-08-18 19:34:11.383004874 +0200
+++ b/drivers/video/fbdev/xilinxfb.c	2017-08-18 19:34:35.383005478 +0200
@@ -100,7 +100,7 @@ struct xilinxfb_platform_data {
 /*
  * Default xilinxfb configuration
  */
-static struct xilinxfb_platform_data xilinx_fb_default_pdata = {
+static const struct xilinxfb_platform_data xilinx_fb_default_pdata = {
 	.xres = 640,
 	.yres = 480,
 	.xvirt = 1024,