linux-kernel - Re: [PATCH v3] blktrace: Fix potentail deadlock between delete & sysfs ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1503079624.2622.10.camel@wdc.com>
Date:   Fri, 18 Aug 2017 18:07:06 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "mingo@...nel.org" <mingo@...nel.org>,
        "longman@...hat.com" <longman@...hat.com>,
        "rostedt@...dmis.org" <rostedt@...dmis.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH v3] blktrace: Fix potentail deadlock between delete &
 sysfs ops

On Fri, 2017-08-18 at 13:54 -0400, Waiman Long wrote:
> Instead, a global blktrace
> mutex will be used to serialize the read/write of the blktrace sysfs
> attributes.

Hello Waiman,

Using a mutex to serialize code is wrong. What is needed is exact
documentation of what data structures and/or member variables are
protected by bdev->bd_mutex and by blktrace_mutex.

Also, please spell "potential" correctly in the subject of this patch.

Thanks,

Bart.