linux-kernel - Re: [PATCH -tip v9 3/5] cris: mark _stext and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 18 Aug 2017 20:38:33 +0200
From:   Jesper Nilsson <jesper.nilsson@...s.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Francis Deslauriers <francis.deslauriers@...icios.com>,
        mathieu.desnoyers@...icios.com, Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Ananth N Mavinakayanahalli <ananth@...ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Chris Zankel <chris@...kel.net>,
        Max Filippov <jcmvbkbc@...il.com>,
        Mikael Starvik <starvik@...s.com>,
        Jesper Nilsson <jespern@...s.com>, linux-cris-kernel@...s.com,
        linux-arch@...r.kernel.org
Subject: Re: [PATCH -tip v9 3/5] cris: mark _stext and _end as char-arrays,
 not single char

On Wed, Aug 16, 2017 at 08:01:33PM +0900, Masami Hiramatsu wrote:
> On Thu,  3 Aug 2017 11:37:15 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > diff --git a/arch/cris/kernel/traps.c b/arch/cris/kernel/traps.c
> > index a01636a12a6e..d98131c45bb5 100644
> > --- a/arch/cris/kernel/traps.c
> > +++ b/arch/cris/kernel/traps.c
> > @@ -42,7 +42,7 @@ void (*nmi_handler)(struct pt_regs *);
> >  void show_trace(unsigned long *stack)
> >  {
> >  	unsigned long addr, module_start, module_end;
> > -	extern char _stext, _etext;
> > +	extern char _stext[], _etext[];
> >  	int i;
> >  
> >  	pr_err("\nCall Trace: ");
> > @@ -69,8 +69,8 @@ void show_trace(unsigned long *stack)
> >  		 * down the cause of the crash will be able to figure
> >  		 * out the call path that was taken.
> >  		 */
> > -		if (((addr >= (unsigned long)&_stext) &&
> > -		     (addr <= (unsigned long)&_etext)) ||
> > +		if (((addr >= (unsigned long)_stext) &&
> > +		     (addr <= (unsigned long)_etext)) ||
> >  		    ((addr >= module_start) && (addr <= module_end))) {
> 
> BTW, I would like to ask cris people, this seems to check over 1 byte,
> since _etext and module_end will be placed at the next byte of the real
> address area.
> As same as other arch, Should it be 
> 
> (addr < (unsigned long)_etext)
> 
> or are there any other reason?

As far as I can tell, this is non-intentional.

> Thank you,

> Masami Hiramatsu <mhiramat@...nel.org>

/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com