linux-kernel - Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP keyboard on reset after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Aug 2017 21:02:48 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Sandeep Singh <Sandeep.Singh@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>
Cc:     stable@...r.kernel.org,
        Nehal Shah <Nehal-bakulchandra.Shah@....com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.12 47/65] usb:xhci:Add quirk for Certain failing HP
 keyboard on reset after resume

On Mon, 2017-08-14 at 18:19 -0700, Greg Kroah-Hartman wrote:
> 4.12-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Sandeep Singh <sandeep.singh@....com>
> 
> commit e788787ef4f9c24aafefc480a8da5f92b914e5e6 upstream.
[...]
> --- a/drivers/usb/host/pci-quirks.c
> +++ b/drivers/usb/host/pci-quirks.c
> @@ -98,6 +98,7 @@ enum amd_chipset_gen {
>  	AMD_CHIPSET_HUDSON2,
>  	AMD_CHIPSET_BOLTON,
>  	AMD_CHIPSET_YANGTZE,
> +	AMD_CHIPSET_TAISHAN,
>  	AMD_CHIPSET_UNKNOWN,
>  };
>  
> @@ -141,6 +142,11 @@ static int amd_chipset_sb_type_init(stru
>  			pinfo->sb_type.gen = AMD_CHIPSET_SB700;
>  		else if (rev >= 0x40 && rev <= 0x4f)
>  			pinfo->sb_type.gen = AMD_CHIPSET_SB800;
> +	}
> +	pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
> +					  0x145c, NULL);
> +	if (pinfo->smbus_dev) {
> +		pinfo->sb_type.gen = AMD_CHIPSET_TAISHAN;
>  	} else {
>  		pinfo->smbus_dev = pci_get_device(PCI_VENDOR_ID_AMD,
>  				PCI_DEVICE_ID_AMD_HUDSON2_SMBUS, NULL);
[...]

This causes pinfo->smbus_dev to be wrongly set to NULL on systems with
the ATI chipset that this function checks for first.

Ben.

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)