linux-kernel - [PATCH] freevxfs: Delete an error message for a failed memory allocation in vxfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <56e657d1-1df2-53a5-0ea8-c3e8b158b3e1@users.sourceforge.net>
Date:   Sat, 19 Aug 2017 12:46:53 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Christoph Hellwig <hch@...radead.org>,
        Krzysztof Błaszkowski <kb@...mikro.com.pl>,
        kernel-janitors@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] freevxfs: Delete an error message for a failed memory
 allocation in vxfs_fill_super()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Sat, 19 Aug 2017 12:40:30 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 fs/freevxfs/vxfs_super.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/freevxfs/vxfs_super.c b/fs/freevxfs/vxfs_super.c
index 455ce5b77e9b..9be45aab21f5 100644
--- a/fs/freevxfs/vxfs_super.c
+++ b/fs/freevxfs/vxfs_super.c
@@ -223,10 +223,8 @@ static int vxfs_fill_super(struct super_block *sbp, void *dp, int silent)
 	sbp->s_flags |= MS_RDONLY;
 
 	infp = kzalloc(sizeof(*infp), GFP_KERNEL);
-	if (!infp) {
-		printk(KERN_WARNING "vxfs: unable to allocate incore superblock\n");
+	if (!infp)
 		return -ENOMEM;
-	}
 
 	bsize = sb_min_blocksize(sbp, BLOCK_SIZE);
 	if (!bsize) {
-- 
2.14.0