linux-kernel - Re: [PATCH v2] Do not disable driver and bus shutdown hook when class shutdown hook is set.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170819172959.iu46r2jm7unmbb4x@linux.intel.com>
Date:   Sat, 19 Aug 2017 20:29:59 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Michal Suchanek <msuchanek@...e.de>,
        Peter Huewe <peterhuewe@....de>,
        Marcel Selhorst <tpmdd@...horst.net>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Phil Sutter <phil@....cc>, Josh Zimmerman <joshz@...gle.com>,
        Madalin Bucur <madalin.bucur@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        Ludovic Desroches <ludovic.desroches@...inux.fr>,
        linux-kernel@...r.kernel.org, tpmdd-devel@...ts.sourceforge.net
Subject: Re: [PATCH v2] Do not disable driver and bus shutdown hook when
 class shutdown hook is set.

On Sat, Aug 19, 2017 at 10:03:40AM -0700, Greg Kroah-Hartman wrote:
> On Sat, Aug 19, 2017 at 03:03:53PM +0300, Jarkko Sakkinen wrote:
> > On Fri, Aug 11, 2017 at 03:44:43PM +0200, Michal Suchanek wrote:
> > > As seen from the implementation of the single class shutdown hook this
> > > is not very sound design.
> > > 
> > > Rename the class shutdown hook to shutdown_pre to make it clear it runs
> > > before the driver shutdown hook.
> > > 
> > > Signed-off-by: Michal Suchanek <msuchanek@...e.de>
> > 
> > I already gave this reviewed-by but cannot apply it because there's no
> > ack from device maintainers yet.
> 
> I'm on vacation at the moment and will look at this when I get back in a
> week, please give me a chance.
> 
> thanks,
> 
> greg k-h

Take your time! I don't think this patch is critical. Thanks.

/Jarkko