linux-kernel - Re: [PATCH] PCI: dwc: make dw_pcie_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 19 Aug 2017 16:25:19 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Bhumika Goyal <bhumirks@...il.com>
Cc:     julia.lawall@...6.fr, wangzhou1@...ilicon.com,
        gabriele.paoloni@...wei.com, bhelgaas@...gle.com,
        songxiaowei@...ilicon.com, wangbinghui@...ilicon.com,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCI: dwc: make dw_pcie_host_ops const

On Wed, Aug 09, 2017 at 01:18:48PM +0530, Bhumika Goyal wrote:
> Make these structures const as they are only stored in the ops field of
> a pcie_port structure, which is of type const.
> Done using Coccinelle.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>

Applied to pci/host-hisi and pci/host-kirin for v4.14, thanks!

> ---
>  drivers/pci/dwc/pcie-hisi.c  | 2 +-
>  drivers/pci/dwc/pcie-kirin.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/dwc/pcie-hisi.c b/drivers/pci/dwc/pcie-hisi.c
> index e51acee..518cd7e 100644
> --- a/drivers/pci/dwc/pcie-hisi.c
> +++ b/drivers/pci/dwc/pcie-hisi.c
> @@ -223,7 +223,7 @@ static int hisi_pcie_link_up(struct dw_pcie *pci)
>  	return hisi_pcie->soc_ops->hisi_pcie_link_up(hisi_pcie);
>  }
>  
> -static struct dw_pcie_host_ops hisi_pcie_host_ops = {
> +static const struct dw_pcie_host_ops hisi_pcie_host_ops = {
>  	.rd_own_conf = hisi_pcie_cfg_read,
>  	.wr_own_conf = hisi_pcie_cfg_write,
>  };
> diff --git a/drivers/pci/dwc/pcie-kirin.c b/drivers/pci/dwc/pcie-kirin.c
> index 33fddb9..a623f96 100644
> --- a/drivers/pci/dwc/pcie-kirin.c
> +++ b/drivers/pci/dwc/pcie-kirin.c
> @@ -441,7 +441,7 @@ static void kirin_pcie_host_init(struct pcie_port *pp)
>  	.link_up = kirin_pcie_link_up,
>  };
>  
> -static struct dw_pcie_host_ops kirin_pcie_host_ops = {
> +static const struct dw_pcie_host_ops kirin_pcie_host_ops = {
>  	.rd_own_conf = kirin_pcie_rd_own_conf,
>  	.wr_own_conf = kirin_pcie_wr_own_conf,
>  	.host_init = kirin_pcie_host_init,
> -- 
> 1.9.1
>