[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <6473aa07-e3d6-5b2b-39d4-38456cf7b301@gmail.com>
Date: Fri, 18 Aug 2017 20:05:52 -0400
From: Harinath Nampally <harinath922@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: Martin Kepplinger <martink@...teo.de>,
Peter Meerwald-Stadler <pmeerw@...erw.net>, knaack.h@....de,
lars@...afoo.de, gregkh@...uxfoundation.org,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
amsfield22@...il.com
Subject: Re: [PATCH] iio: accel: mma8452: Bugfix to enbale and allow different
events to work parallely.
> This patch fixes by detaching the event related information from
> chip_info struct,
>>> and based on channel type and event direction the corresponding
> event configuration registers
>>> are picked dynamically. Hence multiple events can be handled in
> read/write callbacks.
>> which chip can have which event(s)?
> I am planning to add 'supported events' field in
> One small point. Don't put the word bugfix in the title (and fix
> spelling of enable!). I know this is obviously a false restriction
> on the driver, but it doesn't not work, it is just limited in features
> without this.
Sure, thanks for letting me know.
On 08/17/2017 10:40 AM, Jonathan Cameron wrote:
>>> This patch fixes by detaching the event related information from
>>> chip_info struct,
>>>>> and based on channel type and event direction the corresponding
>>> event configuration registers
>>>>> are picked dynamically. Hence multiple events can be handled in
>>> read/write callbacks.
>>>> which chip can have which event(s)?
>>> I am planning to add 'supported events' field in
> One small point. Don't put the word bugfix in the title (and fix
> spelling of enable!). I know this is obviously a false restriction
> on the driver, but it doesn't not work, it is just limited in features
> without this.
Powered by blists - more mailing lists